refactor: [CYBERSOURCE, BANKOFAMERICA, WELLSFARGO] Move code to crate hyperswitch_connectors #6908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awasthi21
added
A-connector-integration
awasthi21
force-pushed
the
connector-crate-move
branch
from
37ec9b0 to
deb2edb
Compare
2 tasks
awasthi21
force-pushed
the
connector-crate-move
branch
from
1e0ba96 to
1ec7b93
Compare
deepanshu-iiitu
requested changes
Dec 26, 2024
| fn is_auto_capture(&self) -> Result<bool, Error>; | ||
| fn get_order_details(&self) -> Result<Vec<OrderDetailsWithAmount>, Error>; | ||
| fn get_webhook_url(&self) -> Result<String, Error>; | ||
| fn get_return_url(&self) -> Result<String, Error>; |
There was a problem hiding this comment.
Rename function to get_router_return_url
awasthi21
force-pushed
the
connector-crate-move
branch
from
6a5c99d to
616296f
Compare
awasthi21
force-pushed
the
connector-crate-move
branch
from
616296f to
15d646b
Compare
deepanshu-iiitu
approved these changes
Dec 27, 2024
Comment on lines
+46
to
+50
| /// Error message for Authentication Error from the connector | ||
| pub const CONNECTOR_UNAUTHORIZED_ERROR: &str = "Authentication Error from the connector"; | ||
|
|
||
| /// Error message when Refund request has been voided. | ||
| pub const REFUND_VOIDED: &str = "Refund request has been voided."; |
There was a problem hiding this comment.
Can we move these 2 consts to the hyperswitch_connectors crate itself?
| @@ -41,7 +41,6 @@ pub const DEFAULT_LIST_API_LIMIT: u16 = 10; | |||
| pub(crate) const UNSUPPORTED_ERROR_MESSAGE: &str = "Unsupported response type"; | |||
| pub(crate) const LOW_BALANCE_ERROR_MESSAGE: &str = "Insufficient balance in the payment method"; | |||
| pub(crate) const CONNECTOR_UNAUTHORIZED_ERROR: &str = "Authentication Error from the connector"; | |||
There was a problem hiding this comment.
Aren't we removing the const from here, since it would be moved to the hyperswitch_connectors crate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Move cybersource, bankofamerica, wellsfargo code to crate hyperswitch_connectors.
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy