refactor(router): refactor relay flow addressing comments of /relay feature pr
#6954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
| @@ -32,7 +32,7 @@ pub async fn construct_relay_refund_router_data<'a, F>( | |||
| let webhook_url = Some(payments::helpers::create_webhook_url( | |||
| &state.base_url.clone(), | |||
| merchant_id, | |||
| connector_name, | |||
| connector_account.merchant_connector_id.get_string_repr(), | |||
There was a problem hiding this comment.
Can we have the function itself accept &MerchantConnectorAccountId? Update the usages of the function elsewhere as well.
There was a problem hiding this comment.
For reference, the same change had been taken up in #6631, but that PR seems to have gone stale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
relay feature pr #6879
This PR refactors the relay flow to address the comments from the relay feature PR
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy