Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest use StdIn.ReadLine instend of Predef.ReadLine cause Predef.ReadLine has been deprecated #547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zsdz
Copy link

@zsdz zsdz commented Jan 12, 2021

method ReadLine defined in predef has been deprecated since scala 2.11.0

I change the code with StdIn.ReadLine in step0_repl.scala,and it works fine

If this pull will be accepted,I will change other code in the files

@kanaka
Copy link
Owner

kanaka commented Apr 21, 2021

@zsdz sorry for the very slow followup. I would definitely consider merging this if you changed all the files and also cleaned up the commit to have a better commit summary like "[scala] use StdIn.ReadLine instead of deprecated Predef.readLine" and if you can, add a link in the commit body to a notice of this being deprecated.

@zsdz
Copy link
Author

zsdz commented Apr 23, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants