BQN implementation #619
Open
BQN implementation #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: add varargs support to dissoc and assoc
The MAL suggestion is to use a regex for tokenizing. But that's boring (and BQN doesn't have regex support yet). So I wrote a recursive tokenizer, but now self-hosting tokenizes long enough pieces of code to cause a stack overflow. So rewrite as a loop instead.
|
Anything I can do to get this merged? |
|
@kanaka is there anything I could do to help get this PR merged? |
|
Still hoping to get this merged! |
kanaka
requested changes
Aug 7, 2024
There was a problem hiding this comment.
Hello @dancek sorry for the very slow reply (I've been unable to work on this project for the past couple of years but I'm am able to again). If you're still interested in getting this merged upstream I would ask that you do the following:
- Rebase the code onto the current HEAD
- The recommended process has changed slightly: the eval_ast is no longer seperate from eval. It would be good if you could update to follow the new structure.
- Add your implementation to
IMPLS.ymland make sure that the CI tests all pass for your implementation.
|
Glad to hear from you! Thanks for the pointers. It may take me a while but I do intend to finish this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation in BQN, a modern array programming language. The code is idiomatic where possible but sometimes overly verbose. Also, parts of the MAL guide forced a non-array-y implementation – but I still followed the guide.
I didn't implement optional functionality; specifically
with-metawould be quite annoying to add due to all data types and every match expression needing to be changed accordingly. The language doesn't have builtin support for properties, hashmaps or such.CBQN is currently the main implementation of the language, and it's the only one supported as documented in README. Adapting to another implementation would be very simple, though, as the
_while_2-modifier could be implemented in a line of BQN and the terminal goodies are not strictly necessary.