refactor: ♻️ add substance-combobox.tsx #469
Conversation
|
🚅 Deployed to the neuronek-pr-469 environment in neuronek
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 160b913 in 43 seconds
More details
- Looked at
476lines of code in7files - Skipped
1files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_5xvPxTXOurDWBGLY
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 5 days left in your free trial, upgrade for $20/seat/month or contact us.
| const [open, setOpen] = useState(false); | ||
| const [value, setValue] = useState(""); | ||
|
|
||
| const frameworks = [ |
There was a problem hiding this comment.
The SubstanceCombobox component is hardcoded with framework data, which seems incorrect for a component intended to select substances. Consider fetching and using actual substance data here.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on bb97776 in 55 seconds
More details
- Looked at
289lines of code in4files - Skipped
1files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_7HDq6F8HBFe33e2B
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 5 days left in your free trial, upgrade for $20/seat/month or contact us.
| return ( | ||
| <Combobox | ||
| mode='single' //single or multiple | ||
| options={[]} |
There was a problem hiding this comment.
The options prop is passed an empty array, which means no options will be displayed in the Combobox. You should pass the frameworks array to the options prop to display the intended options.
| options={[]} | |
| options={frameworks} |
|
Okay... I kinda must spend a lot more time on this, or find another approach for ingestion page. |
keinsell
force-pushed
the
trunk
branch
2 times, most recently
from
8f71d72 to
5444560
Compare
Summary:
Introduced new components (
SubstanceCombobox,Combobox,ScrollArea), updated dependencies, and ensured integration and code quality.Key points:
SubstanceComboboxfor framework selectionComboboxcomponent supporting single and multiple selections@radix-ui/react-dialog,@radix-ui/react-popover,cmdkScrollAreacomponent for scrollable areasSubstanceComboboxintoCreateIngestionPageGenerated with ❤️ by ellipsis.dev