-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pug to benchmarks #352
base: master
Are you sure you want to change the base?
Conversation
|
|
||
const templates = { | ||
purchase: pug.compile(` | ||
.purchase.purchase-card |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this isn't the intended use for DX pug; please write it in a way that actually utilizes .pug files.
"outDir": "dist", | ||
"module": "Node16", | ||
"target": "ESNext", | ||
"jsx": "react-jsx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsx isn't needed here
Could you also run the benchmark locally and paste the results here so I can have an idea? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 434 434
=========================================
Hits 434 434 ☔ View full report in Codecov by Sentry. |
add benchmrk for pug