Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pug to benchmarks #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add pug to benchmarks #352

wants to merge 1 commit into from

Conversation

cjhw
Copy link

@cjhw cjhw commented Dec 12, 2024

add benchmrk for pug

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: aaadb34

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR


const templates = {
purchase: pug.compile(`
.purchase.purchase-card
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this isn't the intended use for DX pug; please write it in a way that actually utilizes .pug files.

"outDir": "dist",
"module": "Node16",
"target": "ESNext",
"jsx": "react-jsx",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsx isn't needed here

@arthurfiorette
Copy link
Member

Could you also run the benchmark locally and paste the results here so I can have an idea?

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eda217b) to head (aaadb34).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #352   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          434       434           
=========================================
  Hits           434       434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants