Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSOC] optuna suggestion service logic update #2446

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

[GSOC] optuna suggestion service logic update #2446

wants to merge 28 commits into from

Conversation

shashank-iitbhu
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2374

Checklist:

  • Docs included if any changes are user facing

shashank-iitbhu and others added 28 commits August 22, 2024 03:29
@shashank-iitbhu
hyperopt suggestion logic update
f615e3f 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
Merge upstream master and resolve conflicts in base_service.py and se…
a8bc887 
…arch_space.py
@shashank-iitbhu
fix
a67f373 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
DISTRIBUTION_UNKNOWN enum set to 0 in gRPC api
365c2f5 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
convert parameter method fix
caa2422 
Signed-off-by: Shashank Mittal <[email protected]>

validation fix

add e2e tests for hyperopt

added e2e test to workflow
@shashank-iitbhu
convert feasibleSpace func updated
0f38a51 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
renamed DISTRIBUTION_UNKNOWN to DISTRIBUTION_UNSPECIFIED
ae9fa34 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
fix
910a46c 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
added more test cases for hyperopt distributions
08b01ac 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
added support for NORMAL and LOG_NORMAL in hyperopt suggestion service
16dc030 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
added e2e tests for NORMAL and LOG_NORMAL
282f81d 
Signed-off-by: Shashank Mittal <[email protected]>

sigma calculation fixed

fix

parse new arguments to mnist.py
@shashank-iitbhu
hyperopt-suggestion example update
b7d09a6 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
updated logic for log distributions
58ab1ac 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
updated logic for log distributions
2b1932e 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
e2e test fixed
2f1c355 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
added support for parameter distributions for Parameter type INT
8391c29 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
unit test fixed
23fd30b 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu @tenzen-y
Update pkg/suggestion/v1beta1/hyperopt/base_service.py
7f6deb5 
Co-authored-by: Yuki Iwai <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
comment fixed
b85b4bf 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
added unit tests for INT parameter type
dc36303 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
completed param unit test cases
658daaf 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
handled default case for normal distributions when min or max are not…
5198ad1 
… specified

Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
fixed validation logic for min and max
262912d 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
removed unnecessary test params
81f5526 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
fixes
748e4ba 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
added comments
14f30a5 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
fix
4f35663 
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu
initial logic update
edf98f0 
Signed-off-by: Shashank Mittal <[email protected]>
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shashank-iitbhu shashank-iitbhu marked this pull request as draft October 20, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anencore94 anencore94 Awaiting requested review from anencore94

@Electronic-Waste Electronic-Waste Awaiting requested review from Electronic-Waste

Assignees
No one assigned
Labels
do-not-merge/work-in-progress size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GSOC] Project 8: Support various Parameter Distribution in Katib
1 participant
@shashank-iitbhu