-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WebSocket to get global settings #2008
Use WebSocket to get global settings #2008
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2008 +/- ##
==========================================
+ Coverage 68.67% 68.79% +0.12%
==========================================
Files 248 248
Lines 9168 9169 +1
Branches 1170 1169 -1
==========================================
+ Hits 6296 6308 +12
+ Misses 2866 2855 -11
Partials 6 6
Continue to review full report at Codecov.
|
/assign @floreks |
@maciaszczykm: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
@floreks Please take another look, it seems that I have fixed existing problems already. Please also test it, there is no hurry with it and I'd like to be sure that nothing breaks. /assign @kgroschoff Please verify it too if you can. |
/lgtm |
LGTM label has been added. Git tree hash: 158872838ad4a357f4a3ff886f8cd4bc24df1889
|
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #1903.Special notes for your reviewer:
changeOrigin: true
in our proxy configurations doesn't change theOrigin
header butHost
(Update options.changeOrigin description in docs chimurai/http-proxy-middleware#141). Backend is checking for theOrigin
header as it does not allow cross-origin requests. It will not be a problem as both UI and API will be normally served on the same host, but it was a problem for our development setup.headers: {'Origin': 'https://dev.kubermatic.io'}
solves that problem as the proxy will override theOrigin
header too. I am leaving it there as it was extremely hard to find it as Angular CLI uses webpack-dev-server which uses http-middleware-proxy and each one of them has different configuration which are not documented.Release note: