Update to latest kube-opeapi to drop govalidator dependency #5825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Davanum Srinivas <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dims
force-pushed
the
update-to-latest-kube-api-to-drop-govalidator-dependency
branch
7 times, most recently
from
7c4852e to
f266228
Compare
Signed-off-by: Davanum Srinivas <[email protected]>
dims
force-pushed
the
update-to-latest-kube-api-to-drop-govalidator-dependency
branch
from
f266228 to
84e6594
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: kubernetes/kube-openapi#518
xref: kubernetes/kube-openapi#512
xref: kubernetes/kubernetes#128573
We are looking to drop the
github.com/asaskevich/govalidatoras a dependency. To do this, we essentially ran the following commands in all the directories with a go.mod file as the latestkube-openapihas a commit that removes this dependency.