Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cli tests for vcpctl #70

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Add cli tests for vcpctl #70

merged 1 commit into from
Oct 9, 2018

Conversation

fanzhangio
Copy link

@fanzhangio fanzhangio commented Sep 28, 2018 •
edited
Loading

Add unit tests for client and user
Issue #47

To run these tests, VC_TEST env should be set up

export VC_TEST_URL=<VC URL>
export VC_TEST_PASSWORD=<VC password>
export VC_TEST_USERNAME=<VC username>

@dougm @frapposelli

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2018
@fanzhangio fanzhangio force-pushed the vcpctl-test branch 2 times, most recently from 95c3eaa to c8d9e14 Compare September 28, 2018 07:32
@frapposelli
Copy link
Member

Are these tests running with make test?

@fanzhangio
Copy link
Author

fanzhangio commented Sep 28, 2018 •
edited
Loading

@frapposelli The tests can be run by make file but need to add VC_TEST envs

To run these tests, VC_TEST env should be set up

export VC_TEST_URL=<VC URL>
export VC_TEST_PASSWORD=<VC password>
export VC_TEST_USERNAME=<VC username>

@frapposelli
Copy link
Member

@fanzhangio can you test against vcsim?

@frapposelli
Copy link
Member

/retest

@frapposelli
Copy link
Member

/retest

looks like there's something wrong with the infra

@frapposelli
Copy link
Member

/retest

@fanzhangio
Copy link
Author

/test pull-cloud-provider-vsphere-test

@figo figo mentioned this pull request Oct 9, 2018
Merged
@frapposelli
Copy link
Member

/retest

@figo
Copy link
Contributor

figo commented Oct 9, 2018

/test pull-cloud-provider-vsphere-test

1 similar comment
@figo
Copy link
Contributor

figo commented Oct 9, 2018

/test pull-cloud-provider-vsphere-test

@frapposelli
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frapposelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit 907b545 into kubernetes:master Oct 9, 2018
@fanzhangio fanzhangio deleted the vcpctl-test branch October 10, 2018 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm Awaiting requested review from dougm

@luomiao luomiao Awaiting requested review from luomiao

Assignees

@frapposelli frapposelli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fanzhangio @frapposelli @figo @k8s-ci-robot