-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate scripts from OpenResty to NJS #12403
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elizabeth-dev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @elizabeth-dev. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
cc @rikatz |
8ed9770
to
4d61aae
Compare
e9cc596
to
cf12a71
Compare
cf12a71
to
0c91114
Compare
@elizabeth-dev I will try to review it this or next week (sorry, full queue here). Can we do separated PRs for each migrated feature? This way, if something bad happens is easier to revert just one :D |
@rikatz thanks, and no worries! and sure, I'll open a separate PR for each feature, along with one for adding NJS itself. |
/close as a separate PR will be opened for each migrated feature |
What this PR does / why we need it:
Work in progress... Will update description eventually, meanwhile, here's what has been migrated:
Types of changes
Which issue/s this PR fixes
fixes #12383
How Has This Been Tested?
Checklist: