Avoid parent process if no log redirection is used #3624

mback2k · 2024-05-23T18:32:17Z

What type of PR is this?

/kind design

What this PR does / why we need it:

Exec the command without forking in case go-runner does not need to perform log output redirection.

The idea here is to save resources by exec'ing instead of fork'ing the subprocess to avoid an unnecessary process lingering around.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Not sure if this is a desired change, please review and decide if generally useful or not. Thanks!

Does this PR introduce a user-facing change?

Yes

Avoid parent go-runner process if no log redirection is used, action required: may impact process-based monitoring solutions.

linux-foundation-easycla · 2024-05-23T18:32:22Z

The committers listed above are authorized under a signed CLA.

✅ login: mback2k / name: Marc Hörsken (2e7e2d8)

k8s-ci-robot · 2024-05-23T18:32:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mback2k
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

images/build/go-runner/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2024-05-23T18:32:26Z

Welcome @mback2k!

It looks like this is your first PR to kubernetes/release 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/release has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-05-23T18:32:27Z

Hi @mback2k. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Exec the command without forking in case go-runner does not need to perform log output redirection. Signed-off-by: Marc Hoersken <[email protected]>

saschagrunert · 2024-05-28T07:11:09Z

images/build/go-runner/go-runner.go

@@ -79,7 +80,11 @@ func configureAndRun() error {
 	cmd.Stderr = errStream

 	log.Printf("Running command:\n%v", cmdInfo(cmd))
-	err := cmd.Start()
+	if cmd.Stdout == os.Stdout && cmd.Stderr == os.Stderr {
+		err = syscall.Exec(cmd.Path, cmd.Args, syscall.Environ())


Hm, this feels like a potentially breaking change. Shall we make it an optional feature or such?

I agree, but the idea was to automatically/intelligently save systems resources by avoiding the parent process (go-runner) if not needed. What do you think about an opt-out argument/flag?

xmudrii · 2024-05-28T09:35:45Z

@mback2k Thank your for the contribution! I agree with @saschagrunert that this should probably be an option. Additionally, can you please clarify (e.g. in the PR description) why do you think this change is needed and what do we get from it?

k8s-triage-robot · 2024-09-01T19:31:28Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-10-01T20:13:25Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

mback2k · 2024-10-02T19:23:07Z

@mback2k Thank your for the contribution! I agree with @saschagrunert that this should probably be an option. Additionally, can you please clarify (e.g. in the PR description) why do you think this change is needed and what do we get from it?

Sorry for the delay, I just added "The idea here is to save resources by exec'ing instead of fork'ing the subprocess to avoid an unnecessary process lingering around."

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 23, 2024

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 23, 2024

k8s-ci-robot requested review from jimangel and jrsapi May 23, 2024 18:32

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 23, 2024

Avoid parent process if no log redirection is used

2e7e2d8

Exec the command without forking in case go-runner does not need to perform log output redirection. Signed-off-by: Marc Hoersken <[email protected]>

mback2k force-pushed the master branch from 46b84f1 to 2e7e2d8 Compare May 23, 2024 18:47

mback2k marked this pull request as ready for review May 23, 2024 18:47

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2024

k8s-ci-robot requested a review from salaxander May 23, 2024 18:47

saschagrunert reviewed May 28, 2024

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 1, 2024

mback2k requested a review from saschagrunert October 10, 2024 09:35

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid parent process if no log redirection is used #3624

Avoid parent process if no log redirection is used #3624

mback2k commented May 23, 2024 •

edited

Loading

linux-foundation-easycla bot commented May 23, 2024 •

edited

Loading

k8s-ci-robot commented May 23, 2024

k8s-ci-robot commented May 23, 2024

k8s-ci-robot commented May 23, 2024

saschagrunert May 28, 2024

mback2k Jun 3, 2024

xmudrii commented May 28, 2024

k8s-triage-robot commented Sep 1, 2024

k8s-triage-robot commented Oct 1, 2024

mback2k commented Oct 2, 2024 •

edited

Loading

Avoid parent process if no log redirection is used #3624

Are you sure you want to change the base?

Avoid parent process if no log redirection is used #3624

Conversation

mback2k commented May 23, 2024 • edited Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

linux-foundation-easycla bot commented May 23, 2024 • edited Loading

k8s-ci-robot commented May 23, 2024

k8s-ci-robot commented May 23, 2024

k8s-ci-robot commented May 23, 2024

saschagrunert May 28, 2024

Choose a reason for hiding this comment

mback2k Jun 3, 2024

Choose a reason for hiding this comment

xmudrii commented May 28, 2024

k8s-triage-robot commented Sep 1, 2024

k8s-triage-robot commented Oct 1, 2024

mback2k commented Oct 2, 2024 • edited Loading

mback2k commented May 23, 2024 •

edited

Loading

linux-foundation-easycla bot commented May 23, 2024 •

edited

Loading

mback2k commented Oct 2, 2024 •

edited

Loading