Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved scanning script from test-infra to security-tooling #128

Conversation

Dylan-G-Roberts
Copy link
Contributor

First PR for #60

Just moving the file over, next step is calling it as outlined here: #61 (comment)

Copy link

linux-foundation-easycla bot commented Nov 18, 2024

CLA Signed

  • ✅login: Dylan-G-Roberts / (4e563b1)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 18, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Dylan-G-Roberts!

It looks like this is your first PR to kubernetes/sig-security 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/sig-security has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 18, 2024
@tabbysable
Copy link
Member

Diffed this locally against the version from kubernetes/test-infra#33817 and it all matches.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@smarticu5
Copy link

I've also checked against https://github.com/kubernetes/test-infra/pull/33817/files, and happy that it matches.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@smarticu5: changing LGTM is restricted to collaborators

In response to this:

I've also checked against https://github.com/kubernetes/test-infra/pull/33817/files, and happy that it matches.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@smarticu5
Copy link

Now that I've approved a change, can I add the label?

(Apologies for potential update spam, I'm learning in public here)

/lgtm

@k8s-ci-robot
Copy link
Contributor

@smarticu5: changing LGTM is restricted to collaborators

In response to this:

Now that I've approved a change, can I add the label?

(Apologies for potential update spam, I'm learning in public here)

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust those two nice people manually checking!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dylan-G-Roberts, mtardy, smarticu5, tabbysable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8266bc8 into kubernetes:main Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants