Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd: remove performance ratio periodic jobs #33425

Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Sep 5, 2024

The current performance ratio periodic jobs have been constantly failing for some time due to a new team taking over etcd-io/etcd#16467 and with the learnings that we got when we initially implemented these jobs, and with a highly likely new direction. It doesn't make sense to keep them running.

Closes etcd-io/etcd#17754.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 5, 2024
@ivanvc
Copy link
Member Author

ivanvc commented Sep 5, 2024

/cc @dims @serathius @jmhbnz

@k8s-ci-robot k8s-ci-robot requested review from dims and jmhbnz September 5, 2024 05:24
@serathius
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit d8b8154 into kubernetes:master Sep 5, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ivanvc: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-periodics.yaml using file config/jobs/etcd/etcd-periodics.yaml

In response to this:

The current performance ratio periodic jobs have been constantly failing for some time due to a new team taking over etcd-io/etcd#16467 and with the learnings that we got when we initially implemented these jobs, and with a highly likely new direction. It doesn't make sense to keep them running.

Closes etcd-io/etcd#17754.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc ivanvc deleted the remove-etcd-performance-periodics branch September 5, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Prow job to run periodic performance benchmarks
3 participants