Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIG Architecture Enhancements spotlight #47902

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add SIG Architecture Enhancements spotlight #47902

wants to merge 2 commits into from

Conversation

fsmunoz
Copy link
Contributor

@fsmunoz fsmunoz commented Sep 12, 2024

Add SIG Architecture: Enhancements spotlight article.

contrib-site PR: kubernetes/contributor-site#526

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2024
@fsmunoz fsmunoz mentioned this pull request Sep 12, 2024
Open
@netlify Netlify
Copy link

netlify bot commented Sep 12, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1acc3a7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6740a88daa8e8d00081084e9
😎 Deploy Preview https://deploy-preview-47902--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ArvindParekh
ArvindParekh reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@ArvindParekh ArvindParekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor spelling nits — rest all looks good.

content/en/blog/_posts/2024-09-18-sig-arch-enhancements-spotlight.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-09-18-sig-arch-enhancements-spotlight.md Outdated Show resolved Hide resolved
colossus06
colossus06 reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@colossus06 colossus06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Some nits.

content/en/blog/_posts/2024-09-18-sig-arch-enhancements-spotlight.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-09-18-sig-arch-enhancements-spotlight.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-09-18-sig-arch-enhancements-spotlight.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-09-18-sig-arch-enhancements-spotlight.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-09-18-sig-arch-enhancements-spotlight.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-09-18-sig-arch-enhancements-spotlight.md Outdated Show resolved Hide resolved
@fsmunoz @ArvindParekh @colossus06
Add SIG Architecture Enhancements spotlight
036a986 
Co-authored-by: Arvind <[email protected]>
Co-authored-by: Gulcan Topcu <[email protected]>
@fsmunoz fsmunoz force-pushed the sig-arch-enhancements-spotlight branch from 461f543 to 036a986 Compare October 30, 2024 09:36
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Oct 30, 2024

@colossus06 ty, applied and rebased. this should be good to go (I also updated and rebased the contributor-site PR).

@sftim
Copy link
Contributor

sftim commented Nov 11, 2024

This looks ready for review. If you're reading this, and you agreed to abide by Kubernetes community guidelines: congratulations, you can review (at least informally)!

See https://kubernetes.io/docs/contribute/review/reviewing-prs/#blog for some hints.

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Nov 22, 2024

Updated publication date.

@Gauravpadam
Copy link
Member

Thanks @fsmunoz, We'll get a publication date assigned, keeping it on hold until this is done.
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a9136f231b9acbf4bf8aa513fff325444f454110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colossus06 colossus06 colossus06 left review comments

@ArvindParekh ArvindParekh ArvindParekh left review comments

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@Gauravpadam Gauravpadam

Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Planned
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fsmunoz @k8s-ci-robot @sftim @Gauravpadam @ArvindParekh @colossus06