Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhanced memory pressure eviction #568

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

LuyaoZhong and others added 4 commits May 6, 2024 11:20
1. prioritize evicting the pod for which stats were found
2. support minimun interval for enhanced numa pressure eviction
Signed-off-by: linzhecheng <[email protected]>
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 69.68085% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 56.10%. Comparing base (7a1e3f1) to head (0a20203).
Report is 4 commits behind head on main.

Files Patch % Lines
...ionmanager/plugin/memory/enhanced_numa_pressure.go 76.10% 28 Missing and 10 partials ⚠️
...ent/evictionmanager/plugin/memory/numa_pressure.go 0.00% 11 Missing and 1 partial ⚠️
...amic/adminqos/eviction/memory_pressure_eviction.go 50.00% 4 Missing ⚠️
pkg/util/general/deepcopy.go 71.42% 1 Missing and 1 partial ⚠️
pkg/agent/evictionmanager/plugin/memory/helper.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   55.94%   56.10%   +0.15%     
==========================================
  Files         532      533       +1     
  Lines       49593    49827     +234     
==========================================
+ Hits        27744    27953     +209     
+ Misses      18316    18313       -3     
- Partials     3533     3561      +28     
Flag Coverage Δ
unittest 56.10% <69.68%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants