-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding support to qos level memory.low protection #635
Open
lubinszARM
wants to merge
3
commits into
kubewharf:main
Choose a base branch
from
lubinszARM:pr_mem_protection_qos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubinszARM
force-pushed
the
pr_mem_protection_qos
branch
5 times, most recently
from
June 24, 2024 10:01
32f2163
to
d0c7a14
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 56.96% 56.92% -0.05%
==========================================
Files 553 554 +1
Lines 53161 53353 +192
==========================================
+ Hits 30284 30372 +88
- Misses 19073 19179 +106
+ Partials 3804 3802 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lubinszARM
force-pushed
the
pr_mem_protection_qos
branch
6 times, most recently
from
July 17, 2024 09:02
88b69d6
to
b2642dd
Compare
lubinszARM
force-pushed
the
pr_mem_protection_qos
branch
3 times, most recently
from
July 25, 2024 10:30
77b657b
to
5117199
Compare
Signed-off-by: Robin Lu <[email protected]>
lubinszARM
force-pushed
the
pr_mem_protection_qos
branch
3 times, most recently
from
July 25, 2024 15:51
c5b0cce
to
046a65e
Compare
Signed-off-by: Robin Lu <[email protected]>
This patch provied the feature of memory.low protection. There are a couple of benefits about memory.low protection: 1, it provides a gradient of protection. As a cgroup's usage grows past the protected amount, the protected amount remains protected, but reclaim pressure for the excess amount gradually increases. 2, it's work-conserving - if the protected cgroup doesn't use the memory, it's available for others to use. Signed-off-by: Robin Lu <[email protected]>
lubinszARM
force-pushed
the
pr_mem_protection_qos
branch
from
July 29, 2024 02:35
046a65e
to
47a0e4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
It provides a gradient of file-memory protection for high qos tasks under kswapd memory pressure.
Which issue(s) this PR fixes:
Optimize stability under heavy thrashing (hot memory exhaustion) scenarios
Special notes for your reviewer:
None