Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): support cpu burst #713

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

caohe
Copy link
Member

@caohe caohe commented Oct 30, 2024

What type of PR is this?

Features

What this PR does / why we need it:

Support cpu burst feature in cpu plugin native policy.

Which issue(s) this PR fixes:

Special notes for your reviewer:

kubewharf/katalyst-api#101 needs to be merged first.

@caohe caohe added the enhancement New feature or request label Oct 30, 2024
@caohe caohe force-pushed the cpu-burst branch 2 times, most recently from 7ae0e8d to 2a47758 Compare October 30, 2024 09:58
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 140 lines in your changes missing coverage. Please review.

Project coverage is 55.76%. Comparing base (4fe5c45) to head (466fb54).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
pkg/agent/qrm-plugins/cpu/nativepolicy/policy.go 3.44% 54 Missing and 2 partials ⚠️
pkg/agent/qrm-plugins/cpu/util/util.go 0.00% 32 Missing ⚠️
pkg/util/qos/cpu_enhancement.go 0.00% 15 Missing ⚠️
pkg/util/cgroup/manager/cgroup.go 14.28% 11 Missing and 1 partial ⚠️
pkg/util/cgroup/manager/v1/fs_linux.go 0.00% 7 Missing and 1 partial ⚠️
pkg/util/cgroup/manager/v2/fs_linux.go 0.00% 7 Missing and 1 partial ⚠️
pkg/util/native/resources.go 0.00% 5 Missing ⚠️
cmd/katalyst-agent/app/options/qrm/cpu_plugin.go 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
- Coverage   55.92%   55.76%   -0.16%     
==========================================
  Files         576      594      +18     
  Lines       67022    67984     +962     
==========================================
+ Hits        37479    37909     +430     
- Misses      25559    26048     +489     
- Partials     3984     4027      +43     
Flag Coverage Δ
unittest 55.76% <6.66%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant