-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(qrm-plugins): synchronous GetAdvice API between qrm-plugins and sys-advisor #747
base: main
Are you sure you want to change the base?
Conversation
6a46b8a
to
b1bd308
Compare
505ec78
to
473cb31
Compare
@@ -26,6 +26,9 @@ coverage: | |||
|
|||
ignore: | |||
- "**/*_generated.*" | |||
- "pkg/agent/qrm-plugins/cpu/dynamicpolicy/cpuadvisor/cpu.pb.go" | |||
- "pkg/agent/qrm-plugins/advisorsvc/advisor_svc.pb.go" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can also use generic match such as "*.pb.go"
} | ||
} | ||
|
||
if err := ms.metaCache.RangeAndDeleteContainer(func(container *types.ContainerInfo) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whether it will dead lock for it acquiring metaCache lock multiple times?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, line 141 acquires metaCache.Mutex
, while line 153 acquires metaCache.podMutex
.
…that support GetAdvice
What type of PR is this?
Replace
ListAndWatch
api from sysadvisor with synchronousGetAdvice
rpc.What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: