MariaDB vector store implementation. #7360
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the MariaDB vectorstore implementation. see https://mariadb.org/projects/mariadb-vector/
Key Features
Test
Filtering proposal
This PR contains a proposal to unify filtering data. I might have not understood stuctured query well, but goal of this framework is to permit unifying behavior and it doesn't feel this part has succeed in it.
I'll detail what i've submitted, i'll let you judge if accurate or not.
There is now a new package "@langchain/core/filter"
an example of database filter implementation:
A builder permit to create the filter, and vectorstore implementation will convert it to expected format :
(Ideally, a text parser using antlr to generate the expression from a standardized query would next the next step)
When requiring the corresponding SQL to a filter expression, each vector store needs to implement a filter implementation, extending BaseFilterExpressionConverter. This prevent SQL injection, unify behavior, and permit any kind of filtering, like IN, NOT, gouping ...
(a database filtering implementation must be probably maximum 20 significant lines of code, mainly because each database use his specific JSON functions)