Bagatur/rfc pred eval inline #1236
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ankush Gola <[email protected]>
Co-authored-by: Bagatur <[email protected]>
…i/langsmith-sdk into isaac/multipartstuff
| self._store_results = store_results | ||
|
|
||
| @property | ||
| def _example_count(self) -> int: |
There was a problem hiding this comment.
we have a count endpoint now you could prob use for this?
| yield experiment_row | ||
|
|
||
| async for result in aitertools.aiter_with_concurrency( | ||
| max_concurrency, predict_all(), _eager_consumption_timeout=0.001 |
There was a problem hiding this comment.
Is there a way to push this concurrency down to the predict_all layer, so we grab an example, then concurrently run over each example? Does the aforward and arun_evaluators get run sequentially per thread?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.