Add inline evaluation results for summary evaluators #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacoblee93
reviewed
Dec 21, 2024
| evaluationResults: Array<ExperimentResultRow> | ||
| ) => EvaluationResult | EvaluationResults; | ||
|
|
||
| type AsyncSummaryEvaluator = ( |
There was a problem hiding this comment.
Why is this different from SummaryEvaluatorT?
There was a problem hiding this comment.
This is what we wrap the evaluator to internally, I do not believe it is user facing.
jacoblee93
reviewed
Dec 21, 2024
| @@ -133,13 +145,17 @@ interface _ExperimentManagerArgs { | |||
| runs?: AsyncGenerator<Run>; | |||
| evaluationResults?: AsyncGenerator<EvaluationResults>; | |||
| summaryResults?: AsyncGenerator< | |||
| (runsArray: Run[]) => AsyncGenerator<EvaluationResults, any, unknown>, | |||
| ( | |||
There was a problem hiding this comment.
This is a weird typing - isn't it breaking since you now have to specify evaluationResults?
There was a problem hiding this comment.
Ah yeah - can I just make evaluationResults an optional param? Or is there a better solution to make this non breaking?
jacoblee93
reviewed
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.