Remove mvvmlight dependency #504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
reviewed
Oct 7, 2021
Comment on lines
98
to
101
| [SuppressMessage("Microsoft.Performance", "CA1822:MarkMembersAsStatic", | ||
| Justification = "The this keyword is used in the Silverlight version")] | ||
| [SuppressMessage("Microsoft.Design", "CA1030:UseEventsWhereAppropriate", | ||
| Justification = "This cannot be an event")] |
There was a problem hiding this comment.
❔ Are these still needed?
There was a problem hiding this comment.
WOW you are so fast to react 💨
Good point @sharwell I will have a second 👁👁 on it
Comment on lines
+16
to
+18
| public virtual void Cleanup() | ||
| { | ||
| } |
|
|
||
| protected void RaisePropertyChanged([CallerMemberName] string propertyName = null) | ||
| { | ||
| PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName)); |
There was a problem hiding this comment.
💡 If this is called a large number of times, consider caching the PropertyChangedEventArgs instances in a concurrent dictionary.
laurentkempe
force-pushed
the
remove-mvvmlight-dependency
branch
from
1f51c25 to
74d3e15
Compare
sharwell
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.