Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RingTheory): support of quotient module #20292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Dec 28, 2024


Open in Gitpod

@github-actions github-actions bot added large-import Automatically added label for PRs with a significant increase in transitive imports t-algebra Algebra (groups, rings, fields, etc) labels Dec 28, 2024
Copy link

PR summary e7c3bc9644

Import changes exceeding 2%

% File
+15.03% Mathlib.RingTheory.Support

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.Support 1131 1301 +170 (+15.03%)
Mathlib.Algebra.Module.LocalizedModule.Submodule 991 1008 +17 (+1.72%)
Import changes for all files
Files Import difference
Mathlib.Algebra.Module.LocalizedModule.Submodule 17
Mathlib.AlgebraicGeometry.PrimeSpectrum.Module 140
Mathlib.RingTheory.Support 170

Declarations diff

+ Module.support_quotient
+ localized₀_smul

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@erdOne
Copy link
Member Author

erdOne commented Dec 29, 2024

I personally think the increase in import is fine as this is a leaf file, but if reviewers think otherwise I'm happy to split it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large-import Automatically added label for PRs with a significant increase in transitive imports t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant