Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to run node shell on Bootlerocket and Windows nodes #7965

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dex4er
Copy link
Contributor

@dex4er dex4er commented Oct 23, 2023

This is a reworked node-shell feature. It allows to run it on Bottlerocket OS and Windows nodes where there is no sh nor bash command.

Unfortunately, node-shell pods cannot be autoremoved anymore with sleep command. It is because now single pod is created and then kubectl attach is run. It is because kubectl exec with nsenter command won't work: Bottlerocket OS is SELinux hardened then nsenter won't have privileges to run in kubectl exec context.

Anyway: node-shell pods are correctly removed after the terminal is closed.

Because Windows needs separate image, there is a separate setting now:

image

Node shell for Ubuntu:

image

Node shell for Bottlerocket:

image

Node shell for Windows 2022:

image

@dex4er dex4er requested a review from a team as a code owner October 23, 2023 09:09
@dex4er dex4er requested review from ixrock and aleksfront and removed request for a team October 23, 2023 09:09
@dex4er dex4er force-pushed the feature/node-shell-windows branch from 00eb857 to 83b2ce6 Compare October 23, 2023 09:09
@moebaca
Copy link

moebaca commented Feb 13, 2024

Any update on this? Would love to pop into Bottlerocket using Lens like I do for AL2.

@ajaykumarmandapati
Copy link

Would this be available soon? 🙏🏾

@ixrock ixrock requested review from a team, ixrock and Nokel81 and removed request for ixrock, aleksfront and a team April 8, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants