Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIXED: issue #4 #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

FIXED: issue #4 #7

wants to merge 2 commits into from

Conversation

htharoldht
Copy link

Fix the bug that the page does not update after using dynamic-image layout #4

@htharoldht
FIXED: issue lightvue#4
6ca6576 
Fix the bug that the page does not update after using this layout
@MatthewCushing
Copy link

Any update on this?

@htharoldht
Copy link
Author

htharoldht commented Aug 10, 2022 •
edited
Loading

Only one root node <div></div> is added, which can fix #4

@MatthewCushing
Copy link

Just a heads up. This works, you just didn't close the <div> tag on line 3. Put the closing > character on the div and the checks should pass

@htharoldht
Copy link
Author

Got it, I'll pr again. Thanks

@MatthewCushing
Copy link

MatthewCushing commented Aug 10, 2022 •
edited
Loading

Odd that it failed. Something to do with Vite plugin 404'ing from Netlify

3:16:13 AM: [vite-plugin-remote-assets] Request failed with status code 404

Code works though 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@htharoldht @MatthewCushing