Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UIE-8350] - IAM RBAC: Fix Invalid routes are accessible #11436

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aaleksee-akamai
Copy link
Contributor

Description 📝

Prevent routing to non-existent and invalid URLs, such as:
/iam/invalid,
/iam/invalid/page,
/iam/users/invalid/page,
/iam/roles/invalid,
/iam/roles/invalid/page,
/iam/users/{username}/invalid,
/iam/users/{username}/invalid/page,
/iam/users/{username}/details/invalid,
/iam/users/{username}/details/invalid/page,
/iam/users/{username}/roles/invalid,
/iam/users/{username}/roles/invalid/page,

Changes 🔄

List any change(s) relevant to the reviewer.

  • change url from /iam/users/{username}/resources to /iam/users/{username}/entities

Target release date 🗓️

1/14/25 (dev)

How to test 🧪

Prerequisites

  • Ensure the Identity and Access Beta flag is enabled in dev tools
  • Use urls from the description

Verification steps

(How to verify changes)

  • Ensure that all invalid routes are redirected to the first tab.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@aaleksee-akamai aaleksee-akamai requested a review from a team as a code owner December 18, 2024 12:48
@aaleksee-akamai aaleksee-akamai requested review from carrillo-erik and hkhalil-akamai and removed request for a team December 18, 2024 12:48
@aaleksee-akamai aaleksee-akamai force-pushed the UIE-8350-iam-rbac-fix-invalid-routes branch from 453ad7d to d501a56 Compare December 18, 2024 12:49
@aaleksee-akamai aaleksee-akamai self-assigned this Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

Coverage Report:
Base Coverage: 86.94%
Current Coverage: 86.96%

@cpathipa cpathipa requested review from cpathipa and removed request for carrillo-erik December 18, 2024 14:34
@aaleksee-akamai aaleksee-akamai force-pushed the UIE-8350-iam-rbac-fix-invalid-routes branch 2 times, most recently from 421ec0f to ca5340b Compare December 20, 2024 13:05
@aaleksee-akamai aaleksee-akamai force-pushed the UIE-8350-iam-rbac-fix-invalid-routes branch from ca5340b to 36d1237 Compare December 20, 2024 13:19
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing471 Passing2 Skipped94m 28s

Details

Failing Tests
SpecTest
lke-update.spec.tsLKE cluster updates » can add and delete node pool tags

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/kubernetes/lke-update.spec.ts"

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants