-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [UIE-8350] - IAM RBAC: Fix Invalid routes are accessible #11436
Open
aaleksee-akamai
wants to merge
1
commit into
linode:develop
Choose a base branch
from
aaleksee-akamai:UIE-8350-iam-rbac-fix-invalid-routes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: [UIE-8350] - IAM RBAC: Fix Invalid routes are accessible #11436
aaleksee-akamai
wants to merge
1
commit into
linode:develop
from
aaleksee-akamai:UIE-8350-iam-rbac-fix-invalid-routes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaleksee-akamai
requested review from
carrillo-erik and
hkhalil-akamai
and removed request for
a team
December 18, 2024 12:48
aaleksee-akamai
force-pushed
the
UIE-8350-iam-rbac-fix-invalid-routes
branch
from
December 18, 2024 12:49
453ad7d
to
d501a56
Compare
Coverage Report: ✅ |
cpathipa
requested review from
cpathipa
and removed request for
carrillo-erik
December 18, 2024 14:34
aaleksee-akamai
force-pushed
the
UIE-8350-iam-rbac-fix-invalid-routes
branch
2 times, most recently
from
December 20, 2024 13:05
421ec0f
to
ca5340b
Compare
aaleksee-akamai
force-pushed
the
UIE-8350-iam-rbac-fix-invalid-routes
branch
from
December 20, 2024 13:19
ca5340b
to
36d1237
Compare
Cloud Manager UI test results🔺 1 failing test on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/kubernetes/lke-update.spec.ts" |
jaalah-akamai
approved these changes
Dec 21, 2024
jaalah-akamai
added
Ready for Review
Add'tl Approval Needed
Waiting on another approval!
and removed
Requires Changes
labels
Dec 21, 2024
bnussman-akamai
approved these changes
Dec 23, 2024
bnussman-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Prevent routing to non-existent and invalid URLs, such as:
/iam/invalid
,/iam/invalid/page
,/iam/users/invalid/page
,/iam/roles/invalid
,/iam/roles/invalid/page
,/iam/users/{username}/invalid
,/iam/users/{username}/invalid/page
,/iam/users/{username}/details/invalid
,/iam/users/{username}/details/invalid/page
,/iam/users/{username}/roles/invalid
,/iam/users/{username}/roles/invalid/page
,Changes 🔄
List any change(s) relevant to the reviewer.
/iam/users/{username}/resources
to/iam/users/{username}/entities
Target release date 🗓️
1/14/25 (dev)
How to test 🧪
Prerequisites
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅