Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7706, 9005] - Set VPC interface as primary when creating a Linode #11450

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Dec 20, 2024

Description 📝

Sets VPC interfaces as the primary interface when creating a Linode - this had been lost in the refactor.

See internal ticket 7706 for details of investigation. This does not resolve the unrecommended config notice for already existing Linodes, just for newly created ones. Customers with this notice on their Linode will need to manually edit their configs to resolve it.

The bug with the Linode Config Dialog should be resolved in #11424

Target release date 🗓️

1/14

Preview 📷

Before After
image image

How to test 🧪

Reproduction steps

  • Create a Linode (assign it to a VPC in the creation flow)
  • Note how inside the VPC, the Linode has an 'unrecommended config' notice

Verification steps

  • Following the same steps above, confirm that a newly created Linode will not have unrecommended config notice
  • Confirm that any time a Linode is created with a VPC interface, the VPC interface will be marked as primary (test with/without Vlans and private IPs)
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@coliu-akamai coliu-akamai added Bug Fixes for regressions or bugs VPC Relating to VPC project labels Dec 20, 2024
@coliu-akamai coliu-akamai self-assigned this Dec 20, 2024
Comment on lines 213 to 215
if (hasVLAN) {
return [publicInterface, vlanInterface];
}
Copy link
Contributor Author

@coliu-akamai coliu-akamai Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither publicInterface nor vlanInterface were marked as primary previously, and in the API spec linked in internal ticket 7706 notes that vlans cannot be the primary interface

@coliu-akamai coliu-akamai marked this pull request as ready for review December 20, 2024 17:58
@coliu-akamai coliu-akamai requested a review from a team as a code owner December 20, 2024 17:58
@coliu-akamai coliu-akamai requested review from bnussman-akamai and cpathipa and removed request for a team December 20, 2024 17:58
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing471 Passing2 Skipped116m 56s

Details

Failing Tests
SpecTest
clone-linode.spec.tsclone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixes for regressions or bugs VPC Relating to VPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants