fix blacklisting of perl files via blacklist_interp #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0f80a34, the files() method started returning paths like: /proc/521178/root//usr/share/perl5/Foo/Bar.pm ...rather than: /usr/share/perl5/Foo/Bar.pm This breaks the use of configuration such as: $nrconf{blacklist_interp} = [ @{$nrconf{blacklist_interp}}, qr(^/usr/share/perl5/Foo/), ]; If I understand correctly, the intent is to scan files within the per-process root as described in proc_pid_root(5). This patch should still respect that. Notes: * The code is already statting files within the per-process root; without this patch, the paths to stat have `/proc/<pid>/root/` prepended twice, resulting in e.g.: `/proc/521178/root//proc/521178/root//usr/share/perl5/Foo/Bar.pm` With this patch, `/proc/<pid>/root/` is only prepended once. * Without this patch, when files are read in _scan(), the executable script (e.g. `/usr/local/bin/foo.pl`) is not opened using the path to the per-process root. With this patch, all files are opened using the per-process root. * With this patch, `needrestart -v` prints paths without the per-process root, matching earlier behavior. * This behavior may apply to other interpreters as well; I have only examined the handling of Perl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0f80a34, the files() method started returning paths like:
...rather than:
This breaks the use of configuration such as:
If I understand correctly, the intent is to scan files within the per-process root as described in proc_pid_root(5). This patch should still respect that.
Notes:
/proc/<pid>/root/prepended twice, resulting in e.g.:/proc/521178/root//proc/521178/root//usr/share/perl5/Foo/Bar.pmWith this patch,/proc/<pid>/root/is only prepended once./usr/local/bin/foo.pl) is not opened using the path to the per-process root. With this patch, all files are opened using the per-process root.needrestart -vprints paths without the per-process root, matching earlier behavior.