-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[circt-test] fix SymbiYosys integration test #7886
base: main
Are you sure you want to change the base?
Conversation
a771274
to
ccfacf5
Compare
https://github.com/llvm/circt/actions/runs/11998261862/job/33447711728#step:5:330 |
Good thinking! We should definitely add SymbiYosys to the set of tools installed for integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot for fixing this!
If you would like to land this yourself once CI passes, feel free to obtain commit access to LLVM. Otherwise let me know and I can merge things for you 😃 |
@unlsycn I have added SymbiYosys and a more up-to-date build of Yosys to the integration test CI image (v18.0) in #7895. I'll land that in a few minutes if CI passes. Once that's in main, you could try to rebase this PR onto main and see if the integration test CI picks up the SymbiYosys installation and the test you fixed here now runs 🙂 |
ccfacf5
to
7a2a321
Compare
It looks like something might be broken in the integration image's sby setup 😞, sorry about that. This is going to be a bit annoying to debug. One approach could be to tweak the |
Signed-off-by: unlsycn <[email protected]>
7a2a321
to
79d6f5f
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We can rerun the ci now since it is merged. |
hmmmm..I forgot that the image has not been released. I can pass all the tests on my machine with the latest docker image. |
#7756 adds the SymbiYosys test runner and requires the
sby
feature, but did not add the corresponding available feature inlit.cfg.py
, so this test never seems to run, and #7763 introduces a syntax error, a backslash in the f-string expression part, in the Python script.Unlike #7884, there is no need to modify PATH variable for the script since
sby
should be in the PATH if we can check it in CMake.