[RTG][Elaboration] Do not internalize primitive values #7997
+507
−392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElaboratorValue
directly, but let it have a pointer to a storage which is internalized. This storage pointer can be used to directly store primitive values, thus avoiding internalization:index
type valuesi1
type valuesDenseSet<StorageTy *>
with a custom MapInfo that does actual value comparison instead of comparing pointers: performs very well when all values internalized are unique (i.e., no equivalent object is already in the set, ever), but not very well when the object is equivalent to an already internalized one most of the timeFoldingSet<StorageTy>
: performs worse than the above in the first case, but considerably better when the object is already in the set, because it avoids unnecessary malloc+freeStorageUniquer.cpp