[ImportVerilog] Add foreach statement support. #8017
+145
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Maybe you can refer to the implementation of Handle repeat loops. We can pass the cond to the BB1 when we enter. I guess this method can reduce accessing memory(like read and blokcing_assign ops) frequently 🤔. WDYT @fabianschuiki?
| @@ -7,6 +7,7 @@ | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| #include "ImportVerilogInternals.h" | |||
| #include "mlir/IR/Diagnostics.h" | |||
There was a problem hiding this comment.
nit: Don't include extra unnecessary headers.
Comment on lines
+549
to
+550
| // CHECK: moore.blocking_assign %[[I]], %[[ADD2]] : i32 | ||
| // CHECK: cf.br ^[[BB1]] |
There was a problem hiding this comment.
Referring to repeat loops, we can avoid creating blocking_assign.
hailongSun2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add forloop statement support, due to lack of dyn array support, currently static-length array is supported.