Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flang-new -> flang renaming article #62

Open
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

DavidSpickett
Copy link
Contributor

@DavidSpickett DavidSpickett commented Nov 14, 2024

Note: This article is to be published just after the release of LLVM 20, around Feburary 2025.

Which will be the first release that includes LLVM Flang as flang instead of flang-new.

The original proposal being https://discourse.llvm.org/t/proposal-rename-flang-new-to-flang/69462.

I proposed writing this article (https://discourse.llvm.org/t/rfc-llvm-project-blog-post-for-flang-new-flang-renaming/80915) to mark that renaming.

It covers:

  • Why fortran still exists.
  • Why you would build a new compiler.
  • Flang's history.
  • How the community decided to rename it.
  • Flang's adoption of MLIR.
  • Quotes from users/contributors/etc.
  • How to contribute to Flang.

@DavidSpickett
Copy link
Contributor Author

DavidSpickett commented Nov 14, 2024

I am posting this very early relative to the likely February publishing date so we have plenty of time to gather feedback with all the holidays coming up.

It is ready for review, though the main focus at the moment is factual accuracy and general layout. I will concentrate on grammar and phrasing later, I have some reviewers in mind for that. I suggest you use the "rich" diff view so you can read the rendered Markdown document.

I am also collecting quotes for the article. Some of you I will be emailing directly, but anyone can be included and you can comment here instead. I cannot guarantee all input will be used but you of course have the right to ask that a quote be removed or corrected or put in the proper context if it is used.

(reading or reviewing the whole article is not required to give a quote, it's here for inspiration if you need it)

Quotes can be about anything related to the project:

  • Could be something that Flang allowed you to build
  • work that you enjoyed doing on Flang
  • something you think Flang has set a new standard for
  • how Flang contributes to your company/institution's strategy.

The goal is to show the breadth of the community and all the unique things people have got/continue to get from this project.

Please keep your quotes to a few sentences if possible.

If you have a particular way you wish to be cited, please let me know. My default is what I see on GitHub and the git log, plus the company name. If you want something different please tell me exactly what you prefer it to be, include:

  • Any special characters or formatting.
  • Translated forms of the name, e.g Japanese Kanji and a Romanised version, I'll include both.
  • Your job title if you want that included
  • Your company name, if you want it included

@DavidSpickett DavidSpickett marked this pull request as ready for review November 14, 2024 11:15
Copy link

@banach-space banach-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, David. This reads really well, and it’s clear you’ve put in a lot of detective work to gather all this information - it’s greatly appreciated!

I’ve left a few minor comments and suggestions. After reading through, I see that you actually address most of these later in the text :)

I’ll aim to contribute something on the driver in the next few days.

content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
@DavidSpickett
Copy link
Contributor Author

I’ve left a few minor comments and suggestions. After reading through, I see that you actually address most of these later in the text :)

These sort of comments are good to. Sometimes it's good for the reader to have questions for later, but if it's something they're going to be distracted by as they read, I should address that.

@DavidSpickett
Copy link
Contributor Author

FYI: big updates to the FIR and HLFIR sections coming, you can still point out my mistakes though :)

Copy link

@luporl luporl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few nits, but the MLIR part looks good to me.

content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
@DavidSpickett
Copy link
Contributor Author

DavidSpickett commented Nov 19, 2024

I added a few nits, but the MLIR part looks good to me.

Thanks Leandro! I will be re-ordering the section soon, after I have more input from some Nvidia folks but I expect the factual content to be the same.

content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
Copy link

@luporl luporl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great explanation of OpenMP basics, illustrated with how Clang translates it to LLVM IR and contrasted with Flang, that first lowers it to MLIR.

content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
content/posts/2024-11-05-flang-new.md Outdated Show resolved Hide resolved
@erjin
Copy link

erjin commented Nov 27, 2024

I do like how the #OpenMP to Everyone section introduces OpenMP from the basics and progressively delves into the differences between Clang and Flang in code generation.

@everythingfunctional
Copy link

I just gave it a full read through and I really like it. Thank you very much for putting this together. I look forward to seeing it published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants