Add simple GithubAction for Tox #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We do have CI for that already: |
|
Oh sorry I did not see these. I just saw that you have open pull requests and they are not checked via any CI. So I thought it would be nice to have automatic CI coverage for these. Setting up Github Actions is quite easy to do, so I just gave it a shot. Looking closer the open Pull Requests are also just automatic PRs for security fixes, so no user interaction there I guess... But you could of course also configure your existing Jenkins server to 1) annotate the commits on GitHub with the build results and 2) to also check pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The low-hanging fruit for automatic checks is probably getting tox executed on Github Actions.
I was able to run
flake8,mypyanddocssuccessfully.However I failed with the test suite. We probably need to set up some more things in the environment...
The output of the Github Actions is visible here: https://github.com/ChristianKuehnel/llvm-lnt/actions