Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new incus_network_peer resource #157

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Unitiser
Copy link
Contributor

Hello,

This is the PR for #123.

@maveonair maveonair requested a review from stgraber November 11, 2024 08:08
@stgraber stgraber added the Incomplete Waiting on more information from reporter label Nov 25, 2024
@stgraber
Copy link
Member

stgraber commented Dec 3, 2024

@Unitiser any chance you can update your PR based on the comments above?
Also, we just merged #173 which comes with a few disabled tests that are waiting on this PR, it'd be great to add a commit which enables them.

@Unitiser
Copy link
Contributor Author

Hello, I apologize for the delay.

I made the fix you requested, hope this helps!

@maveonair maveonair removed the Incomplete Waiting on more information from reporter label Dec 16, 2024
@maveonair
Copy link
Member

@Unitiser Please merge origin main or rebase from origin main to get the latest fixes required for CI/CD to work.

Copy link
Member

@maveonair maveonair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request must be above the latest main branch in order to receive the required corrections for CI/CD

@Unitiser
Copy link
Contributor Author

Unitiser commented Dec 17, 2024

@maveonair I resync'd the branch using the Github UI. Let me know if that's enough.

@stgraber
Copy link
Member

 === RUN   TestAccNetworkIntegration_attach
    resource_network_integration_test.go:99: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: Missing required argument
        
          on terraform_plugin_test.tf line 46, in resource "incus_network_peer" "test":
          46: resource "incus_network_peer" "test" {
        
        The argument "target_network" is required, but no definition was found.
--- FAIL: TestAccNetworkIntegration_attach (0.26s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants