fix(add): prevent errors when supplying dependencies for Nuxt.js template
#246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
force-pushed
the
hotfix/add-deps-nuxt
branch
from
b1cdf41 to
a303d28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
Did you add tests for your changes?
The existing test suite accounts for it.
If relevant, did you update the documentation?
N/A
Summary
Fixes #247
This PR fixes the issue about specifying dependencies to be installed with the
addcommand fails for theNuxt.jstemplate irrespective of the directoryclient/server. The proposed fix skips from performing further configuration if the template chosen isNuxt.jsor the directory isserverregardless of the template. All other starter templates have theclient/src/main.jsas a valid path, which wasn't the case withNuxt.js. For the server directory, this isn't required since all configuration updates happen for dependencies relating to theclient(vuex,vuetify, Nuxt modules, etc).Does this PR introduce a breaking change?
No
Other information
N/A