Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan for security vulnerabilities with GitHub CodeQL #646

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rgoldberg
Copy link
Contributor

Scan for security vulnerabilities with GitHub CodeQL by adding .github/workflows/codeql.yml workflow.

Resolve #645

@rgoldberg rgoldberg added the 🧽 chore Administrative task: documentation, build, test, release, git, etc. label Nov 20, 2024
@rgoldberg rgoldberg self-assigned this Nov 20, 2024
@rgoldberg rgoldberg requested a review from a team as a code owner November 20, 2024 16:33
@rgoldberg rgoldberg added this to the 1.8.8 milestone Nov 21, 2024
@rgoldberg rgoldberg force-pushed the 645-codeql branch 3 times, most recently from 6704118 to 4b89224 Compare November 21, 2024 21:27
@rgoldberg rgoldberg force-pushed the 645-codeql branch 2 times, most recently from 0171f23 to 59f5e54 Compare December 2, 2024 12:30
phatblat
phatblat previously approved these changes Dec 7, 2024
@rgoldberg
Copy link
Contributor Author

rgoldberg commented Dec 7, 2024

@phatblat Thanks for approving. I got the workflows working, but I haven't yet looked through the output of CodeQL, so I'll probably get back to this after the release overhaul is done. I'll also try to ensure that the release overhaul didn't create any security issues by getting to this immediately after finishing the rest of the release process overhaul.

@rgoldberg rgoldberg force-pushed the main branch 7 times, most recently from d2b6f35 to c8dc938 Compare December 27, 2024 05:34
@rgoldberg rgoldberg modified the milestones: 1.8.8, 1.8.9 Dec 27, 2024
Scan for security vulnerabilities with GitHub CodeQL by adding `codeql.yml` workflow.

Partial mas-cli#645

Signed-off-by: Ross Goldberg <[email protected]>
Use `runs-on: macos-15`.

Don't analyze `ruby` or `c-cpp`.

Perform `security-and-quality` queries.

Remove parentheses from job name.

Remove unnecessary settings.

Remove unnecessary comments.

Fix lint spacing violations.

Use double quotes instead of single quotes.

Partial mas-cli#645

Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#645

Signed-off-by: Ross Goldberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan for security vulnerabilities with GitHub CodeQL
2 participants