Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC4247: User Pronouns #4247

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

MSC4247: User Pronouns #4247

wants to merge 12 commits into from

Conversation

everypizza1
Copy link

@everypizza1 everypizza1 commented Dec 27, 2024 •
edited
Loading

turt2live
turt2live reviewed Dec 27, 2024
View reviewed changes
proposals/4247-user-pronouns.md Outdated Show resolved Hide resolved
proposals/4247-user-pronouns.md Outdated Show resolved Hide resolved
proposals/4247-user-pronouns.md Outdated Show resolved Hide resolved
turt2live
turt2live reviewed Dec 27, 2024
View reviewed changes
proposals/4247-user-pronouns.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements:

  • Client
  • Server

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conduwuit already supports this by supporting arbitrary fields in #4133 so I'd assume this MSC only requires a client implementation that can read/write the field?

@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Dec 27, 2024
everypizza1 and others added 3 commits December 27, 2024 11:04
@everypizza1 @turt2live
Link MSC
c18ebc7 
Co-authored-by: Travis Ralston <[email protected]>
@everypizza1 @turt2live
Update number
939b203 
Co-authored-by: Travis Ralston <[email protected]>
@everypizza1
Wrap lines
dc4e203
uhoreg
uhoreg reviewed Dec 27, 2024
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward. A few mostly-nitpicky comments.

proposals/4247-user-pronouns.md Show resolved Hide resolved
proposals/4247-user-pronouns.md Show resolved Hide resolved
proposals/4247-user-pronouns.md Outdated Show resolved Hide resolved
@nexy7574 nexy7574 mentioned this pull request Dec 28, 2024
Open
@nexy7574 nexy7574 mentioned this pull request Dec 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nexy7574 nexy7574 nexy7574 left review comments

@tcpipuk tcpipuk tcpipuk left review comments

@turt2live turt2live turt2live left review comments

@uhoreg uhoreg uhoreg left review comments

Assignees
No one assigned
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@everypizza1 @uhoreg @turt2live @tcpipuk @nexy7574