Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assume UTC in CurlClient, but encourage it in the doc #5682

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Do not assume UTC in CurlClient, but encourage it in the doc #5682

merged 7 commits into from
Sep 25, 2023

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Sep 22, 2023 •
edited
Loading

When emitting shell commands to emulate the native client, the CurlClient incorrectly assumed the input to be qualified UTC timestamps, but they may not be.

Also update the documentation, and the client code to enforce using explicitly timezoned timestamps where necessary (CurlClient), but to continue to allow ints where they are passthrough (HttpxClient).

@achamayou achamayou requested a review from a team September 22, 2023 15:24
@ghost
Copy link

ghost commented Sep 22, 2023 •
edited by ghost
Loading

do_not_assume_but_encourage_utc@76391 aka 20230925.18 vs main ewma over 20 builds from 76003 to 76364

Click to see table

main

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_mt_virtual_cft^ tpcc_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem pi_basic_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
76003 20230919.15 28110.3 2.51822e+07 0.823869 5596.5 8.59996e+07 14103.4 1.88908e+07 14168.3 1.05021e+07 15708.5 1.46964e+07 78893.3 17296.1 1456 1.25993e+07 45430.7 6930.48 1.88908e+07 48253.5 7095.2 6.30784e+06 54962.6 5821.17 1.67936e+07 4451 17315.5 19169.9 5749.41 1.67936e+07 17304 15065.9 3996.53 1.67936e+07 9861.45 45003 836289 1.18821e+06 8.14084e+06 3.21795e+07
76015 20230919.19 28252.3 2.30851e+07 0.780865 5582.98 8.80968e+07 13933.9 1.67936e+07 14063 1.05021e+07 15454.5 1.25993e+07 68481.1 17179.4 1445.3 1.25993e+07 45884.9 6833.42 1.88908e+07 48693.3 6956.1 6.30784e+06 55353.3 5764.29 1.67936e+07 4451.1 17089.2 19693.2 5741.3 1.67936e+07 17055.5 14594.9 3973.09 1.67936e+07 9802.74 43090.7 828277 1.17503e+06 8.16854e+06 3.05736e+07
76054 20230919.37 27635.8 2.30851e+07 0.767755 5608.14 8.59996e+07 14039.8 1.88908e+07 14151.3 1.05021e+07 15693.4 1.25993e+07 84164.5 17131.7 1444.8 1.25993e+07 43642.1 7221.43 1.67936e+07 48127.4 7058.5 6.30784e+06 51879.1 5780.5 1.67936e+07 4461.4 17346.6 19026.2 5743.01 1.67936e+07 17520.1 14884.1 4003.19 1.67936e+07 10064.1 39087.4 834363 1.18202e+06 8.13722e+06 3.07706e+07
76076 20230919.46 27742.6 2.51822e+07 0.841856 5535.46 8.59996e+07 13972.3 1.88908e+07 14006.2 1.05021e+07 15504.1 1.46964e+07 78567.6 17381.2 1431.1 1.25993e+07 45544.3 6868.27 1.88908e+07 47874.6 6991 6.30784e+06 53078.7 5792.24 1.67936e+07 4492.4 17214.5 16564.8 5488.53 1.67936e+07 17135.5 14642.9 3984.22 1.67936e+07 9786.58 44362.7 835522 1.18649e+06 8.15306e+06 3.0439e+07
76097 20230920.1 28027 2.30851e+07 0.771017 5650.74 8.59996e+07 14031.1 1.67936e+07 14131.3 1.05021e+07 15471.1 1.46964e+07 86385.1 17317 1446.5 1.25993e+07 45477.1 6850.31 1.67936e+07 48221.6 6988.2 6.30784e+06 55062.5 5784.34 1.67936e+07 4480.6 17201.5 19641.3 5750.9 1.67936e+07 17217 14623.7 3973.75 1.67936e+07 9757.69 36337.8 833307 1.18308e+06 8.15264e+06 3.09295e+07
76165 20230921.3 27623 2.30851e+07 0.768436 5585.9 8.59996e+07 14067.6 1.67936e+07 14121.5 1.05021e+07 15674.5 1.25993e+07 77456.4 17168.2 1441.9 1.25993e+07 45677.4 6846.38 1.67936e+07 48197.9 7088.4 6.30784e+06 55130.8 5774.38 1.67936e+07 4354.8 17117.4 19846 5777.07 1.67936e+07 17049.8 16843.7 3994.62 1.67936e+07 9885.87 45264.8 841894 1.18293e+06 8.17154e+06 3.14395e+07
76171 20230921.6 28181.5 2.51822e+07 0.835403 5590.06 8.59996e+07 14063.7 1.88908e+07 14139.1 1.05021e+07 15638.1 1.46964e+07 90391.4 17444 1438.5 1.25993e+07 45885 7263.82 1.67936e+07 49813.7 6934.8 6.30784e+06 55693 5777.83 1.67936e+07 4397.5 17248.2 19556.1 5739.47 1.67936e+07 17048.7 14393.6 3979.61 1.67936e+07 9900.28 47592.5 835535 1.18048e+06 8.14991e+06 3.10731e+07
76203 20230921.17 28117.4 2.51822e+07 0.786125 5590.41 8.59996e+07 14046.3 1.88908e+07 14136.2 1.05021e+07 15702.1 1.25993e+07 91230.3 17331.8 1451.3 1.25993e+07 45471.5 7265.93 1.67936e+07 48425.7 6938.8 6.30784e+06 55265.4 5812.78 1.67936e+07 4445 17069.4 19840.5 5731.91 1.88908e+07 17208.3 16828.2 4003.75 1.67936e+07 9850.06 41833.5 828314 1.18182e+06 8.15189e+06 3.14873e+07
76211 20230921.19 28190 2.51822e+07 0.768321 5540.05 8.59996e+07 13915.4 1.88908e+07 14037.6 1.05021e+07 15443.2 1.46964e+07 83281 17227.8 1427 1.25993e+07 45812.6 7200.01 1.88908e+07 48471.5 6829.3 6.30784e+06 54793.9 5793.08 1.67936e+07 4423.3 16980.2 19036 5714.67 1.88908e+07 17505.3 14920.8 4002.62 1.67936e+07 10061.9 42595.5 836057 1.18019e+06 8.15267e+06 3.07739e+07
76229 20230921.26 28059.6 2.51822e+07 0.829414 5652.51 8.59996e+07 14090.4 1.67936e+07 14190.5 1.05021e+07 15600 1.46964e+07 66135.4 17401.8 1447.9 1.25993e+07 43704.7 7298.28 1.67936e+07 47600.2 6978.2 6.30784e+06 53570.9 5830.7 1.67936e+07 4439.6 16987.8 19431.4 5721.21 1.67936e+07 17595.1 14848.4 4004.1 1.67936e+07 10010.4 42758.2 832626 1.17831e+06 8.13609e+06 3.08452e+07
76246 20230921.32 28040.6 2.51822e+07 0.813443 5560.83 8.59996e+07 13924 1.88908e+07 14031.5 1.05021e+07 15320.5 1.46964e+07 90083.2 17276.3 1428.1 1.25993e+07 46143 6841.82 1.67936e+07 48647.1 6915.5 6.30784e+06 55120.7 5775.95 1.67936e+07 4455 17322 19312.1 5741.57 1.88908e+07 16895.7 14660.4 4016.26 1.67936e+07 9783.22 44774.6 836067 1.18217e+06 8.15348e+06 3.24647e+07
76264 20230921.38 28078 2.30851e+07 0.780894 5498.22 8.59996e+07 13944.9 1.67936e+07 14014.4 1.05021e+07 15418.7 1.46964e+07 77135.1 17230 1429.9 1.25993e+07 45759.3 6816.34 1.88908e+07 46429.6 6879.8 6.30784e+06 54858.2 5792 1.67936e+07 4451.4 17199.9 19967.7 5484.27 1.88908e+07 17029.2 15131.4 3997.38 1.67936e+07 9808.43 44676.9 836500 1.18323e+06 8.15426e+06 3.14101e+07
76275 20230921.42 27675.3 2.51822e+07 0.799728 5516.85 8.59996e+07 13833 1.88908e+07 13994.3 1.05021e+07 15323 1.46964e+07 61293.6 17284.6 1428.6 1.25993e+07 45985.5 6814.88 1.88908e+07 48663.5 6957 6.30784e+06 54864.7 5792.76 1.67936e+07 4484.2 17338.3 19110.6 5477.97 1.67936e+07 17422.8 14799.1 3976.18 1.67936e+07 9983.03 43972 834967 1.1818e+06 8.15572e+06 3.13308e+07
76284 20230922.1 27961.4 2.30851e+07 0.795209 5633.54 8.59996e+07 14010.7 1.67936e+07 14106.8 1.05021e+07 15551.8 1.25993e+07 87501.2 17301 1446.7 1.25993e+07 45670.3 6827.79 1.88908e+07 48224.4 6927.2 6.30784e+06 54547.6 5776.51 1.67936e+07 4451.7 17379.9 19636.7 5763.08 1.67936e+07 15047.1 14992.1 4000.17 1.67936e+07 9793.49 42409.1 824925 1.18035e+06 8.1735e+06 3.1513e+07
76298 20230922.7 27722.6 2.30851e+07 0.800525 5594.3 8.59996e+07 14004.8 1.67936e+07 14048.4 1.05021e+07 15518.1 1.25993e+07 74808.3 17323.7 1428.6 1.25993e+07 45640.5 6899.81 1.88908e+07 41875.2 7081.9 6.30784e+06 54379 5779.93 1.67936e+07 4437.9 17134.8 19126.7 5468 1.67936e+07 17461.3 14816.7 3981.43 1.67936e+07 9779.41 44172.3 825413 1.17652e+06 8.15043e+06 3.07277e+07
76315 20230922.13 27876.9 2.30851e+07 0.80863 5538.6 8.59996e+07 13943 1.67936e+07 14077.1 1.05021e+07 15400.6 1.25993e+07 69448.7 17303.6 1435.8 1.25993e+07 45826.4 6800.32 1.88908e+07 48277 6885.7 6.30784e+06 54985.6 5765.87 1.67936e+07 4473.6 17227.3 19660.3 5441.2 1.67936e+07 17271 14960 3999.43 1.67936e+07 9777.67 42190.1 832221 1.17806e+06 8.15602e+06 3.16548e+07
76330 20230922.19 28049.9 2.30851e+07 0.858037 5615.85 8.59996e+07 14027.7 1.67936e+07 14054.2 1.05021e+07 15590.5 1.25993e+07 89163.8 17306.3 1442.4 1.25993e+07 43745.9 6816.46 1.88908e+07 48548.6 6925.9 6.30784e+06 54489 5810.87 1.67936e+07 4421.3 16991.2 19476.1 5790.79 1.67936e+07 17415.7 15098.1 4004.39 1.67936e+07 9979.65 40339.6 828854 1.18105e+06 8.17118e+06 3.07715e+07
76345 20230925.1 28121 2.30851e+07 0.797862 5580.25 8.59996e+07 13980.5 1.88908e+07 14091.4 1.05021e+07 15590.5 1.25993e+07 71294.3 17379.9 1438 1.25993e+07 45613 6912.6 1.88908e+07 48236.5 6932.1 6.30784e+06 54857.8 5804.88 1.67936e+07 4423.1 17220.9 19323.7 5769.73 1.67936e+07 17336.5 15000.3 4001.2 1.67936e+07 9841.31 44686.4 840036 1.17118e+06 8.13205e+06 3.07304e+07
76354 20230925.5 27781.6 2.30851e+07 0.777537 5658.2 8.59996e+07 14047.8 1.88908e+07 14132 1.05021e+07 15677.6 1.25993e+07 66649 17275 1448.6 1.25993e+07 45840.2 6864.84 1.88908e+07 47774.9 7153.1 6.30784e+06 55252.5 5772.5 1.67936e+07 4454.5 16896 19510.3 5787.49 1.67936e+07 17301.6 14893.3 3983.73 1.67936e+07 9953.05 44715.7 829194 1.17874e+06 8.13641e+06 3.2025e+07
76364 20230925.8 27926.4 2.30851e+07 0.794293 5660.35 8.59996e+07 14006.7 1.88908e+07 14101.4 1.05021e+07 15631 1.46964e+07 66865.4 17152.3 1441.2 1.25993e+07 45670.8 6848.56 1.88908e+07 47631.7 6926.3 6.30784e+06 55394.6 5813.72 1.67936e+07 4444.5 17025.6 19263.4 5762.48 1.67936e+07 17562.5 14890 3997.44 1.67936e+07 10304 36232.5 831674 1.18443e+06 8.1528e+06 3.20571e+07

do_not_assume_but_encourage_utc

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem pi_basic_mt_virtual_cft^ Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_full_js_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem hist_sgx_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
76340 20230922.22 28027.6 2.30851e+07 60895 0.797103 17292.5 45542.8 5524.84 8.59996e+07 48472.2 55152.6 4420.3 17014.2 19692.4 17444.5 14027.8 1.88908e+07 14065.7 1.05021e+07 14932.3 15487.4 1.25993e+07 9855.97 1436.9 1.25993e+07 6836.15 1.88908e+07 40790.8 6879 6.30784e+06 5765.42 1.67936e+07 5442.75 1.67936e+07 3995.96 1.67936e+07 842079 1.1794e+06 8.03878e+06 3.12405e+07
76342 20230922.23 27997.9 2.51822e+07 85657.8 0.818899 17066.4 43688.6 5507.58 8.59996e+07 47678.3 54253.5 4405.4 17245.5 18979.3 17358.3 13955.9 1.67936e+07 14094.7 1.05021e+07 14922 15525.8 1.25993e+07 9958.82 1419.4 1.25993e+07 6841.71 1.88908e+07 43966 6980.7 6.30784e+06 5792.07 1.67936e+07 5487.69 1.88908e+07 3996.35 1.67936e+07 838173 1.18093e+06 8.15199e+06 3.08281e+07
76372 20230925.11 28050.9 2.30851e+07 61081.5 0.801783 17372.6 43999.4 5611.6 8.59996e+07 47405.7 55318.9 4405.8 17447.1 19058.1 17151.7 14001.3 1.88908e+07 14033 1.05021e+07 14994.6 15359.2 1.25993e+07 10259.4 1428 1.25993e+07 6795.59 1.67936e+07 44510.9 6917.2 6.30784e+06 5767.8 1.67936e+07 5767.05 1.67936e+07 4001.31 1.67936e+07 831513 1.18693e+06 8.15257e+06 3.10186e+07
76391 20230925.18 27928.4 2.30851e+07 70488.8 0.812504 17147.5 45886.3 5528.05 8.59996e+07 48102.1 54948.2 4416.9 17305.5 19171.8 17596.5 13802.3 1.67936e+07 13938.8 1.05021e+07 15181.2 15235.5 1.25993e+07 10296.5 1418.3 1.25993e+07 6784.56 1.88908e+07 43202.3 6978.9 6.30784e+06 5793.26 1.67936e+07 5474.8 1.67936e+07 3992.6 1.67936e+07 830332 1.18323e+06 8.14755e+06 3.07295e+07

images

@achamayou achamayou added auto-backport Automatically backport this PR to LTS branch 4.x-todo PRs which should be backported to 4.x labels Sep 22, 2023
@achamayou achamayou merged commit fdd38c4 into microsoft:main Sep 25, 2023
20 checks passed
@ghost ghost mentioned this pull request Sep 25, 2023
Merged
ghost pushed a commit that referenced this pull request Sep 25, 2023
@achamayou
Do not assume UTC in CurlClient, but encourage it in the doc (#5682)
d95b3f5 
(cherry picked from commit fdd38c4)
@ghost ghost added the backported This PR was successfully backported to LTS branch label Sep 25, 2023
achamayou pushed a commit that referenced this pull request Sep 26, 2023
[release/4.x] Cherry pick: Do not assume UTC in CurlClient, but encou…
2086a09 
…rage it in the doc (#5682) (#5687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyashton eddyashton eddyashton approved these changes

Assignees
No one assigned
Labels
4.x-todo PRs which should be backported to 4.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achamayou @eddyashton