Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ProfilerProxy linking in InstrumentationEngine.lib #417

Open
WilliamXieMSFT opened this issue Jul 19, 2021 · 0 comments
Open

Remove ProfilerProxy linking in InstrumentationEngine.lib #417

WilliamXieMSFT opened this issue Jul 19, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@WilliamXieMSFT
Copy link
Member

Most of the code isn't needed in the ProfilerProxy and would limit moving the proxy to xplat. Consider moving StringUtils to header-only and remove linking.
@WilliamXieMSFT WilliamXieMSFT added the bug Something isn't working label Jul 19, 2021
@WilliamXieMSFT WilliamXieMSFT changed the title ProfilerProxy links in InstrumentationEngine.lib Remove ProfilerProxy linking in InstrumentationEngine.lib Jul 19, 2021
@delmyers delmyers mentioned this issue Jul 19, 2021
Merged
@WilliamXieMSFT WilliamXieMSFT mentioned this issue Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WilliamXieMSFT