Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert StringUtils to header-only and remove ProfilerProxy linking InstrumentationEngine.Lib #419

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Convert StringUtils to header-only and remove ProfilerProxy linking InstrumentationEngine.Lib #419

merged 3 commits into from
Jul 21, 2021

Conversation

WilliamXieMSFT
Copy link
Member

Addresses #417

@WilliamXieMSFT WilliamXieMSFT requested a review from a team as a code owner July 20, 2021 05:55
@WilliamXieMSFT
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@delmyers
Copy link
Contributor

delmyers commented Jul 21, 2021 •
edited
Loading

class StringUtils

Move to Common.Headers? #Closed

Refers to: src/InstrumentationEngine.Lib/StringUtils.h:8 in 3d85b94. [](commit_id = 3d85b94, deletion_comment = True)

@WilliamXieMSFT
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

delmyers
delmyers approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@delmyers delmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WilliamXieMSFT WilliamXieMSFT merged commit 9ef85a0 into release Jul 21, 2021
@WilliamXieMSFT WilliamXieMSFT deleted the dev/willxie/proxyupdate branch July 21, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delmyers delmyers delmyers approved these changes

Assignees

@delmyers delmyers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamXieMSFT @delmyers