-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building on Windows with presence of Triton #6749
base: master
Are you sure you want to change the base?
Conversation
Hi @woct0rdho - thanks for your contribution. I'll review soon and repro/test on my side as well. But can you share more info about your setup, the error you hit, and things building after? |
Hi @loadams , for the setup, I use Windows 11 23H2 build 22631.4460, MSVC and Windows SDK from VS Build Tools 2022 17.12.0, CUDA 12.5, Python 3.10.10. As a minimal example, I create a fresh venv (not using conda), and install Then I clone the master branch of this repo, and run After some compiling, it shows:
which is because it cannot find the command After fixing this, I run
which is because of the problem of After fixing both errors in this PR, the wheel successfully builds. |
This fixes some errors when installing DeepSpeed on Windows with the presence of Triton.
I guess we can assume we don't need the warning about NFS on Windows for now. I did not try how to detect NFS path on Windows, but we can detect UNC path starting with
\\
if needed.os.rename
does not allow overwriting the file on Windows, andos.replace
is more cross-platform.