Skip to content

Commit

Permalink
fix: Signed build is failing WXS validation (#840)
Browse files Browse the repository at this point in the history
#### Details

The signed release build is including a localization file that is not
included in the other builds. Since the CLI is not yet localized, we are
not including the localized files and should add this file to the list
of files that we intentionally exclude from the MSI package.

##### Motivation

Unblock signed builds

##### Context

<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [n/a] Addresses an existing issue:
  • Loading branch information
DaveTryon authored Nov 15, 2022
1 parent 987a149 commit 26edff0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/MsiFileTests/WxsValidationTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public void AllDropFilesAreAccountedFor()
HashSet<string> productComponentExclusions = new HashSet<string>(StringComparer.OrdinalIgnoreCase)
{
"Axe.Windows.Automation.xml",
"AxeWindowsCLI.dll.lce",
"AxeWindowsCLI.runtimeconfig.dev.json",
};

Expand Down

0 comments on commit 26edff0

Please sign in to comment.