Remove hardcoded calls to System.Diagnostics.Debugger.Break (#350)

microsoft · Apr 9, 2020 · c5b5cc3 · c5b5cc3
1 parent 37c2a2b
commit c5b5cc3
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 18 deletions.
diff --git a/src/Core/Misc/ExtensionMethods.cs b/src/Core/Misc/ExtensionMethods.cs
@@ -418,14 +418,6 @@ public static ScanStatus GetAggregatedScanStatus(this IEnumerable<ScanStatus> ts
                 {
                     return ScanStatus.Uncertain;
                 }
-                else if (HasTestResults(tss, ScanStatus.NoResult))
-                {
-                    // it means that there was no rule executed or 
-                    if (System.Diagnostics.Debugger.IsAttached)
-                    {
-                         System.Diagnostics.Debugger.Break();
-                    }
-                }
 
                 return ScanStatus.Pass;
             }

diff --git a/src/Desktop/UIAutomation/DesktopElement.cs b/src/Desktop/UIAutomation/DesktopElement.cs
@@ -151,10 +151,6 @@ protected override void Dispose(bool disposing)
             catch (Exception e)
             {
                 e.ReportException();
-                if (System.Diagnostics.Debugger.IsAttached)
-                {
-                    System.Diagnostics.Debugger.Break();
-                }
             }
 #pragma warning restore CA1031 // Do not catch general exception types
         }

diff --git a/src/RuleSelection/RuleRunner.cs b/src/RuleSelection/RuleRunner.cs
@@ -27,11 +27,6 @@ public static void Run(A11yElement e)
             catch (Exception ex)
             {
                 ex.ReportException();
-                if (System.Diagnostics.Debugger.IsAttached)
-                {
-                    System.Diagnostics.Debug.WriteLine(ex.ToString());
-                    System.Diagnostics.Debugger.Break();
-                }
             }
 #pragma warning restore CA1031 // Do not catch general exception types
         }

diff --git a/src/Rules/Conditions/Condition.cs b/src/Rules/Conditions/Condition.cs
@@ -74,6 +74,8 @@ public static Condition Create(DelegateCondition.MatchesDelegate d, string descr
 
         public static Condition True = Create(e => true, ConditionDescriptions.True);
         public static Condition False = Create(e => false, ConditionDescriptions.False);
+#if DEBUG
         public static Condition DebugBreak = Create(e => { System.Diagnostics.Debugger.Break(); return true; });
+#endif
     } // class
 } // namespace
diff --git a/src/RulesTest/MonsterTest.cs b/src/RulesTest/MonsterTest.cs
@@ -4,7 +4,6 @@
 using Axe.Windows.Core.Enums;
 using Axe.Windows.UnitTestSharedLibrary;
 using System.Collections.Generic;
-using System.IO;
 using System.Linq;
 using Microsoft.VisualStudio.TestTools.UnitTesting;