Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing Obsoletes: dbus-x11 in dbus.spec #11719

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PawelWMS
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Package build of the oddjob extended package fails, because that package BuildRequires: dbus-x11. We've removed the standalone dbus-x11 package a while ago and replaced it with a Provides in the dbus.spec. We've missed adding an Obsoletes to that spec, however, which caused the build to prefer the old dbus-x11 with a dependency on an older version of dbus, which conflicted with a newer version required through BuildRequires: dbus-devel.

Does this affect the toolchain?

No.

Test Methodology
  • Full dev build 699550.

@PawelWMS PawelWMS requested a review from a team as a code owner December 26, 2024 13:14
@PawelWMS PawelWMS changed the title Pawelwi/dbus x11 fix Added missing Obsoletes: dbus-x11 in dbus.spec Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants