Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hotfix/5.135.6): Use aria-current for active nav links #33390

Open
wants to merge 2 commits into
base: hotfix/5.135.6
Choose a base branch
from
Open

fix(hotfix/5.135.6): Use aria-current for active nav links #33390

wants to merge 2 commits into from
+10 −1

Conversation

gaojian1123
Copy link

@gaojian1123 gaojian1123 commented Dec 3, 2024 •
edited
Loading

Port #11789 to use aria-current for active nav links.

@gaojian1123
Copy link
Author

@TristanWatanabe Could you help review this PR?

@gaojian1123
Copy link
Author

Hi @TristanWatanabe, this change is to fix an accessibility bug in our SharePoint OnPrem project. We need your approval to merge this change into hotfix/5.135.6 branch. If you have any concerns, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phoebe-0319 Phoebe-0319 Phoebe-0319 approved these changes

@TristanWatanabe TristanWatanabe Awaiting requested review from TristanWatanabe TristanWatanabe is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaojian1123 @Phoebe-0319