chore: bump @floating-ui/dom #33458
Open
chore: bump @floating-ui/dom #33458
+35
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
chore/bump-floating-ui
branch
from
4f1eabd to
67b1699
Compare
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
fabricteam
reviewed
Dec 12, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Callout 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Callout.Bottom Right Edge RTL.chromium.png | 1593 | Changed |
| Callout.Bottom auto edge.chromium.png | 2309 | Changed |
| Callout.Left top edge.chromium.png | 1949 | Changed |
| Callout.Bottom left edge.chromium.png | 2309 | Changed |
| Callout.Left center.chromium.png | 2616 | Changed |
react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-AreaChart.Custom Accessibility.chromium.png | 11 | Changed |
react-charting-HeatMapChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-HeatMapChart.Basic.chromium.png | 376 | Changed |
react-charting-LineChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-LineChart.Events.chromium.png | 2 | Changed |
| react-charting-LineChart.Gaps.chromium.png | 1 | Changed |
📊 Bundle size report
Unchanged fixtures
|
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Dec 12, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.chromium.png | 3 | Changed |
| Avatar Converged.Badge Mask RTL.chromium.png | 7 | Changed |
Drawer 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.Full Overlay Dark Mode.chromium.png | 2798 | Changed |
| Drawer.Full Overlay High Contrast.chromium.png | 5191 | Changed |
|
Pull request demo site: URL |
mainframev
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Bumps
@floating-ui/domto the latest version, the change is also done in #33023. I extracted it to a smaller PR to ensure that nothing will break.