Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Collapse): streamline atom functions #33463

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

robertpenner
Copy link
Collaborator

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@robertpenner robertpenner self-assigned this Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
106.859 kB
32.724 kB
106.701 kB
32.732 kB
-158 B
8 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
221.474 kB
64.058 kB
221.316 kB
64.063 kB
-158 B
5 B
react-components
react-components: entire library
1.165 MB
291.795 kB
1.165 MB
291.805 kB
-158 B
10 B
react-toast
Toast (including Toaster)
101.009 kB
30.355 kB
100.851 kB
30.359 kB
-158 B
4 B
react-tree
FlatTree
145.241 kB
41.708 kB
145.081 kB
41.719 kB
-160 B
11 B
react-tree
PersonaFlatTree
145.927 kB
41.819 kB
145.767 kB
41.83 kB
-160 B
11 B
react-tree
PersonaTree
142.16 kB
40.64 kB
142.001 kB
40.645 kB
-159 B
5 B
react-tree
Tree
141.472 kB
40.539 kB
141.313 kB
40.541 kB
-159 B
2 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.21 kB
20.174 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-dialog
Dialog (including children components)
100.196 kB
30.032 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
107.513 kB
35.791 kB
🤖 This report was generated against b59061d2bf717f833fa28c4968b9238f6fdde962

Copy link

Pull request demo site: URL

@robertpenner robertpenner force-pushed the refactor/collapse-atoms branch from 0aea9d7 to 3608e82 Compare December 12, 2024 22:49
@robertpenner robertpenner force-pushed the refactor/collapse-atoms branch 3 times, most recently from cd9ec1a to d84a7fa Compare December 16, 2024 18:31
- put in a new atoms folder that is shared amongst motion components
- rename from opacityAtom to fadeAtom
@robertpenner robertpenner force-pushed the refactor/collapse-atoms branch 2 times, most recently from 65cf213 to 53ccc82 Compare December 18, 2024 17:53
@robertpenner robertpenner force-pushed the refactor/collapse-atoms branch from 53ccc82 to fca343d Compare December 18, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants