Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove deprecation warning from Callout's preventDismissOnResize, etc. #33493

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −12
Open

fix: Remove deprecation warning from Callout's preventDismissOnResize, etc. #33493

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1967667
fix: Remove deprecation warning from Callout's preventDismissOnResize…
behowell Dec 19, 2024
e77a0f9
.api.md
behowell Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/react/src/components/Callout/Callout.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,23 +87,23 @@ export interface ICalloutProps extends React.HTMLAttributes<HTMLDivElement>, Rea
isBeakVisible?: boolean;
Copy link
Collaborator

@fabricteam fabricteam Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv8 Visual Regression Report

Callout 3 screenshots
Image Name Diff(in Pixels) Image Type
Callout.Top center.chromium.png 2178 Changed
Callout.Bottom Right Edge RTL.chromium.png 1593 Changed
Callout.Gap space 25.chromium.png 2309 Changed
react-charting-HeatMapChart 1 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-HeatMapChart.Basic.chromium.png 376 Changed


/**
* If true then the callout will not dismiss on scroll
* If true then the callout will not dismiss on scroll.
* *Note:* This property will be ignored if using `preventDismissOnEvent`.
* @defaultvalue false
* @deprecated use preventDismissOnEvent callback instead
*/
preventDismissOnScroll?: boolean;

/**
* If true then the callout will not dismiss on resize
* If true then the callout will not dismiss on resize.
* *Note:* This property will be ignored if using `preventDismissOnEvent`.
* @defaultvalue false
* @deprecated use preventDismissOnEvent callback instead
*/
preventDismissOnResize?: boolean;

/**
* If true then the callout will not dismiss when it loses focus
* If true then the callout will not dismiss when it loses focus.
* *Note:* This property will be ignored if using `preventDismissOnEvent`.
* @defaultvalue false
* @deprecated use preventDismissOnEvent callback instead
*/
preventDismissOnLostFocus?: boolean;

Expand Down
3 changes: 0 additions & 3 deletions packages/react/src/components/Callout/CalloutContent.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,11 +337,8 @@ function useDismissHandlers(
{
hidden,
onDismiss,
// eslint-disable-next-line deprecation/deprecation
preventDismissOnScroll,
// eslint-disable-next-line deprecation/deprecation
preventDismissOnResize,
// eslint-disable-next-line deprecation/deprecation
preventDismissOnLostFocus,
dismissOnTargetClick,
shouldDismissOnWindowFocus,
Expand Down
Loading