Remove multiline param for panic patterns and add more info in panic msg #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
previously approved these changes
Dec 10, 2024
lubaihua33
force-pushed
the
baihua/panic
branch
from
7fbc8c5 to
56a5754
Compare
|
@LiliDeng LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As users need to refer to the console log when LISA detects the panic, there is no need to match multiline for panic patterns which would bring redundant information in error messages. For example "provision found panic in serial log: ['[ 3.526039] Kernel panic - not syncing: Fatal exception in interrupt\r', '[ 3.526039] ---[ end Kernel panic - not syncing: Fatal exception in interrupt ]---\r', '[ 3.526039] RIP: 0010:0x44\r', '[ 3.526039] RIP: 0010:kernfs_link_sibling+0x33/0xc0\r', '[ 3.526039] RIP: 0010:0x44\r']", the redundant information doesn't make the issue clearer. So I think if we could remove the multiline parameter for panic patterns.